Remove export specific methods form Session #13736
Merged
+633
−495
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DonJayamanne
commented
Jun 21, 2023
| @@ -161,121 +166,79 @@ suite('Jupyter Connection', async () => { | |||
| verify(sessionManager.getRunningKernels()).once(); | |||
| verify(sessionManager.dispose()).once(); | |||
| }); | |||
|
|
|||
| /* eslint-disable , @typescript-eslint/no-explicit-any */ | |||
| suite('JupyterConnection', () => { | |||
There was a problem hiding this comment.
Moved to a separate file, these tests didn't belong here
DonJayamanne
commented
Jun 21, 2023
| } | ||
|
|
||
| // If connecting on HTTP without a token prompt the user that this connection may not be secure | ||
| private async insecureServerWarningPrompt(): Promise<boolean> { |
There was a problem hiding this comment.
Moved from JupyterSessionManager
(unfortunately this introduces a cyclic dependency, but the plan is to fix this)
DonJayamanne
commented
Jun 21, 2023
| @@ -196,53 +192,6 @@ export class JupyterSession | |||
| return promise; | |||
| } | |||
|
|
|||
| async invokeWithFileSynced(contents: string, handler: (file: IBackupFile) => Promise<void>): Promise<void> { | |||
There was a problem hiding this comment.
Now moved into export class
DonJayamanne
commented
Jun 21, 2023
| @@ -339,190 +316,4 @@ export class JupyterSessionManager implements IJupyterSessionManager { | |||
| return []; | |||
| } | |||
| } | |||
|
|
|||
| private async getServerConnectSettings(connInfo: IJupyterConnection): Promise<ServerConnection.ISettings> { | |||
There was a problem hiding this comment.
Moved into JupyterConnection class
alexr00
approved these changes
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13577