Lazy load list of all Python Environments #11674
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DonJayamanne
commented
Oct 16, 2022
| @@ -1913,22 +1913,6 @@ Expand each section to see more information about that event. | |||
| Common measurement used across a number of events. | |||
|
|
|||
|
|
|||
| * DS_INTERNAL.INTERPRETER_LISTING_PERF (Telemetry.InterpreterListingPerf) | |||
There was a problem hiding this comment.
This telemetry is no longer valid, as we no longer have an API to fetch all python enviornments.
Codecov Report
@@ Coverage Diff @@
## main #11674 +/- ##
======================================
- Coverage 62% 62% -1%
======================================
Files 483 483
Lines 34335 34415 +80
Branches 5564 5596 +32
======================================
+ Hits 21577 21617 +40
- Misses 10708 10730 +22
- Partials 2050 2068 +18
|
038c341 to
f6d6ff0
Compare
f6d6ff0 to
93246b8
Compare
DonJayamanne
commented
Oct 17, 2022
|
|
||
| this.updateCache().catch(noop); | ||
|
|
||
| if (Array.isArray(kernelsFromCache) && kernelsFromCache.length > 0) { |
There was a problem hiding this comment.
We need to cache anything anymore, seems pointless and complicated.
Can add this later if we need this.
DonJayamanne
commented
Oct 17, 2022
| @traceDecoratorVerbose('Get Interpreters', TraceOptions.Arguments | TraceOptions.BeforeCall) | ||
| public getInterpreters(): Promise<PythonEnvironment[]> { | ||
| const stopWatch = new StopWatch(); | ||
| private getInterpreters(): Promise<PythonEnvironment[]> { |
There was a problem hiding this comment.
The method getInterrpeters is no longer used, we will not rely on a push model completely.
There was a problem hiding this comment.
Fortunately this was used only in a couple of places in the extension code.
DonJayamanne
commented
Oct 17, 2022
| @@ -72,11 +71,6 @@ export abstract class LocalKernelSpecFinderBase< | |||
| disposables.push(this); | |||
| } | |||
|
|
|||
| @testOnlyMethod() | |||
| public clearCache() { | |||
alexr00
approved these changes
Oct 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7583