Skip to content

Enable IW export on web #10492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jun 17, 2022
Merged

Enable IW export on web #10492

merged 7 commits into from
Jun 17, 2022

Conversation

amunger
Copy link
Contributor

@amunger amunger commented Jun 17, 2022 •
edited
Loading

Fixes #10291

also added an export IW -> notebook test that will run in both desktop and web

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for feature-requests.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).

@amunger amunger requested a review from a team as a code owner June 17, 2022 17:30
@codecov-commenter
Copy link

codecov-commenter commented Jun 17, 2022 •
edited
Loading

Codecov Report

Merging #10492 (4d48ed2) into main (87d0e7f) will increase coverage by 0%.
The diff coverage is 57%.

❗ Current head 4d48ed2 differs from pull request most recent head 1207ff7. Consider uploading reports for the commit 1207ff7 to get more accurate results

@@          Coverage Diff           @@
##            main   #10492   +/-   ##
======================================
  Coverage     70%      71%           
======================================
  Files        467      467           
  Lines      28076    28072    -4     
  Branches    4737     4736    -1     
======================================
+ Hits       19903    19935   +32     
+ Misses      6298     6251   -47     
- Partials    1875     1886   +11
Impacted Files Coverage Δ
...rc/interactive-window/interactiveWindowProvider.ts 77% <ø> (-1%) ⬇️
src/interactive-window/interactiveWindow.ts 74% <25%> (+1%) ⬆️
...ws/extension-side/import-export/jupyterExporter.ts 70% <100%> (ø)
...rc/webviews/extension-side/serviceRegistry.node.ts 100% <100%> (ø)
src/kernels/errors/jupyterInvalidKernelError.ts 62% <0%> (-38%) ⬇️
src/notebooks/outputs/tracebackFormatter.ts 93% <0%> (-7%) ⬇️
...rc/platform/common/dataScienceSurveyBanner.node.ts 65% <0%> (-6%) ⬇️
src/kernels/jupyter/session/jupyterSession.ts 72% <0%> (-3%) ⬇️
src/kernels/variables/kernelVariables.ts 56% <0%> (-2%) ⬇️
src/platform/common/utils/localize.ts 76% <0%> (+<1%) ⬆️
... and 8 more

rebornix
rebornix reviewed Jun 17, 2022
View reviewed changes
src/webviews/extension-side/import-export/jupyterExporter.ts
@@ -8,7 +8,7 @@ import { Uri } from 'vscode';
import { CellMatcher } from '../../../interactive-window/editor-integration/cellMatcher';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Side note for myself (@rebornix). The IW component depends on INotebookExporter directly, maybe we should consider moving it into src/notebooks.

@amunger amunger force-pushed the dev/aamunger/exportIWweb branch from 4d48ed2 to 1207ff7 Compare June 17, 2022 20:55
@amunger amunger merged commit eb2d5c1 into main Jun 17, 2022
@amunger amunger deleted the dev/aamunger/exportIWweb branch June 17, 2022 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IanMatthewHuff IanMatthewHuff IanMatthewHuff approved these changes

@rebornix rebornix rebornix approved these changes

@rchiodo rchiodo rchiodo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Save and Export for IW don't work in web extension
5 participants
@amunger @codecov-commenter @IanMatthewHuff @rebornix @rchiodo