I was out for some of the discussion on this, so I wanted to bump the item for a quick recap.

Current state:

Customers (via issues / request) want the plot viewer
The current method of generating "hidden" SVGs under the surface is crummy, it can slow down execution and bulk up files in a way that customers don't expect
Customers might not care about the "advanced" plot features as opposed to just the ability to view plots off to the side in a separate view from the notebook

Proposed solution(s):

Do nothing, not good. We create a hidden perf issue that hits many customers and is difficult to diagnose (as the SVG is not visible).
Turn off plot viewer by default, customers need to opt in to the setting. Bad as it requires customers to opt into a setting, many will not find it and still has the issue of not knowing which plots will cause massive SVGs.
Same as 2, but leave the button in as a discoverability point, user can click the plot viewer button and if there is not the hidden SVG then we can prompt to turn on the setting (which will warn of the perf cost).
I'm iffy on the technical feasibility here (as the SVG generation is out of our control) but we could look for a way to turn on the setting, but bail out when we are generating SVGs of over a certain size. Like our max output size for streaming output. Then users could opt in to just those plots if they are sure they want them.
Don't generate the hidden SVGs anymore, and instead just use images. If we are working with the current basic plotviewer UI we would need to change the react components to work with images instead of SVGs only like the current implementation. Downside here would be we then wouldn't be supporting SVG plots anymore, which a user might also want in the plot viewer.
Don't generate hidden SVGs. Using the current UI, support both images and SVGs. We could either disable the SVG only features (zoom ect..) or show them only for SVGs. The current UI would need a fair bit of adjustment to support this.
Don't generate hidden SVGs. Ditch the current UI and look at moving over to a more general image viewing control that supports both SVGs and Images. Good time to examine fluent controls as the current plot viewer is not egregious, but also not really slick or VS Code native looking.

SVG Plot viewer perf fix #6913

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions