-
Notifications
You must be signed in to change notification settings - Fork 337
Labels
debtCode quality issuesCode quality issuesnotebook-remoteApplies to remote Jupyter ServersApplies to remote Jupyter Serverson-testplan
Milestone
Description
With the introduction of the new remote finder and server picker experience, we might want to revisit how we are registering kernels from remote uris and what we store in ServerUriStorage
ServerUriStorage
can contain following info- url list
- user provided server urls
- third party contributed server urls
local
when users explicitly set the server toNone
from the server picker
currentServerId
referring to the currently picked entrylocalOnly
referring to if we should connect to local only (❓)
- url list
- Traditional workflow
LocalKernelFinder
contributes all local kernelsRemoteKernelFinder
checksServerUriStorage#currentServerId
and decides if/how to detect kernel specs/sessions- If the selected entry in
ServerUriStorage
islocal
, then it doesn't attempt to scan kernel specs/sessions.
- If the selected entry in
- New workflow
UniversalRemoteKernelFinderController
creates aUniRemoteKernelFinder
for all entries- Each
UniRemoteKernelFinder
follows the same logic asRemoteKernelFinder
, if itsuri
islocal
, it contributes empty kernel specs/sessions.
It would be great if we can move local
out of the ServerUriStorage
and we can simply the RemoteKernelFinder
ctor and registrations into
ServerUriStorage
only holds server uri infos- Traditional remote kernel finder controller
- Hold the
currentSelectedUri
info - Register/dispose remote kernel finder per
currentSelectedUri
update
- Hold the
- New remote kernel finder controller
- Register/dispose all remote kernel finders per
ServerUriStorage#getUris
- Register/dispose all remote kernel finders per
Metadata
Metadata
Assignees
Labels
debtCode quality issuesCode quality issuesnotebook-remoteApplies to remote Jupyter ServersApplies to remote Jupyter Serverson-testplan