-
Notifications
You must be signed in to change notification settings - Fork 338
Closed
Labels
bugIssue identified by VS Code Team member as probable bugIssue identified by VS Code Team member as probable bugipywidgetsRendering, loading, saving, anything to do with IPyWidgetsRendering, loading, saving, anything to do with IPyWidgetsupstream-vscodeBlocked on upstream VS codeBlocked on upstream VS codeverifiedVerification succeededVerification succeeded
Milestone
Description
- Remove the CDN sources (make them blank)
- Connect to a remote server
- Run something that needs a widget
- Widget won't be downloaded
Root cause is the remote cdn provider doesn't do anything except pass the URI up to the webview for downloading. This doesn't work because the webview doesn't have the auth headers (or token) to make a valid request.
I think the solution here is to refactor the CDN downloading code to support the server as a CDN source, but then it would make the appropriate requests with the correct headers, download from the remote jupyter server, and copy the source files to the same spot it does for CDNs.
Essentially remove this source provider and have the CDN code also try kernel's baseURL. Meaning the kernel's base URL is always another CDN source.
Metadata
Metadata
Assignees
Labels
bugIssue identified by VS Code Team member as probable bugIssue identified by VS Code Team member as probable bugipywidgetsRendering, loading, saving, anything to do with IPyWidgetsRendering, loading, saving, anything to do with IPyWidgetsupstream-vscodeBlocked on upstream VS codeBlocked on upstream VS codeverifiedVerification succeededVerification succeeded