Enable tests in CI #110
Merged
Enable tests in CI #110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
which is sent before "close", to prevent test flakiness. Alternatively we could add an error handler to the stream, but this lets us associate the error with the actual code that called 'send' (like to try/catch specific cases)
6314eb8 to
1beaba1
Compare
|
Still failing... |
connor4312
reviewed
Nov 21, 2019
| const runner = new Mocha({ | ||
| timeout: 2000000, | ||
| const mochaOpts = { | ||
| timeout: 10 * 1000, |
There was a problem hiding this comment.
I recently learned that you can do 10_000 now
connor4312
approved these changes
Nov 21, 2019
7343ab2 to
15b4585
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix some flakiness, disable failing tests, and hook up test results view in Azure Pipelines
Fix #28