Added basic telemetry #54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EricCornelson
approved these changes
Oct 28, 2019
roblourens
reviewed
Oct 28, 2019
|
|
||
| export type HighResolutionTime = [number, number]; | ||
|
|
||
| export function calculateElapsedTime(startProcessingTime: HighResolutionTime): number { |
There was a problem hiding this comment.
Is handling nanoseconds overkill? Did we do that before?
There was a problem hiding this comment.
Handling nanoseconds is overkill. We did that before.
For CDP because it's a lot of information, we are going to drop the nanoseconds.
For DAP because it's not that much information, and it's already there, we are leaving it as-is.
src/telemetry/telemetryReporter.ts
Outdated
| // Next line is a sample path aligned with the regexp parts that recognize it/match it. () is for the capture group | ||
| // C : \ foo \ (in.js:) | ||
| // C : \ foo\ble \ (fi.ts:) | ||
| const extractFileNamePattern = /[A-z]:(?:[\\/][^:]*)+[\\/]([^:]*:)/g; |
There was a problem hiding this comment.
I think we need to do this for non-windows paths too.
added 4 commits
October 29, 2019 10:14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added some basic telemetry.
For DAP because they tend to match with user actions, and they seem to be not a lot of quantity, we send the telemetry events individually.
For CDP we get a lot of operations, so we batch them all together.
/* Sample telemetry:
*
{
"cdp/Target.attachedToTarget": {
"succesful": {
"totalTime": 7,
"maxTime": 4,
"avgTime": 2.3333333333333335,
"count": 3,
"breakdown": {
"time": "[1,2,4]",
}
},
<if there are failures, we'll have a failed: section here>
},
"cdp/Debugger.scriptParsed": {
"succesful": {
"totalTime": 8,
"maxTime": 5,
"avgTime": 4,
"count": 2,
"breakdown": {
"time": "[5,3]"
}
}
},
<etc...>
}
}
*/
This is just the first iteration. At the moment we send all the CDP operations batched telemetry when we disconnect.