Update to latest dev container repos and terms #5782
Conversation
There was a problem hiding this comment.
A few suggestions - one is we could probably fix capitalization at the same time so made a number of suggestions there. Not critical tho.
The other broader one is that I don't think we can just point people to the templates repository for examples. Those templates now have an options format and you can't just copy the content to use it.
What I'd suggest is routing people to the Add Dev Container Config UX to add the example is probably a good tactical answer.
(The other thing is generally I've been using the term "Template" to mean what is in devcontainers/templates, but what lands in your project is a "definition"... which is also really the big difference between vscode-dev-containers and this. Those were working "definitions" while these are not.)
Co-authored-by: Chuck Lantz <chuck_lantz@hotmail.com>
Co-authored-by: Chuck Lantz <chuck_lantz@hotmail.com>
Co-authored-by: Chuck Lantz <chuck_lantz@hotmail.com>
Co-authored-by: Chuck Lantz <chuck_lantz@hotmail.com>
Co-authored-by: Chuck Lantz <chuck_lantz@hotmail.com>
Co-authored-by: Chuck Lantz <chuck_lantz@hotmail.com>
Co-authored-by: Chuck Lantz <chuck_lantz@hotmail.com>
Co-authored-by: Chuck Lantz <chuck_lantz@hotmail.com>
Co-authored-by: Chuck Lantz <chuck_lantz@hotmail.com>
Co-authored-by: Chuck Lantz <chuck_lantz@hotmail.com>
|
Thanks for the detailed review @Chuxel! I've incorporated your feedback and would love another review whenever you get a moment. |
Fixes #5736