Skip to content

[marble] Add new port #8628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 47 commits into from
Jul 31, 2020
Merged

[marble] Add new port #8628

merged 47 commits into from
Jul 31, 2020
+154 −0

Conversation

ig-or
Copy link
Contributor

@ig-or ig-or commented Oct 16, 2019 •
edited by LilyWangL
Loading

Probably will not work on Linux/Mac, but lets see.. Supposed to be OK on Windows 10 x64.
Fixes #8602

@msftclas
Copy link

msftclas commented Oct 16, 2019 •
edited
Loading

CLA assistant check
All CLA requirements met.

@PhoebeHui PhoebeHui mentioned this pull request Oct 17, 2019
Closed
PhoebeHui
PhoebeHui reviewed Oct 17, 2019
View reviewed changes
@ig-or
Copy link
Contributor Author

ig-or commented Oct 29, 2019

I'm using vcpkg_fail_port_install.md to specify the platform and architecture that it doesn't support. But still checks are not OK. Should I support all the platforms and configurations?

@ig-or ig-or mentioned this pull request Oct 31, 2019
Closed
JackBoosY
JackBoosY suggested changes Oct 31, 2019
View reviewed changes
@JackBoosY
Copy link
Contributor

@ig-or I have vcpkg_fail_port_install example here:

vcpkg_fail_port_install(ON_TARGET "Windows" "UWP" "OSX" "Linux" "Android" "FreeBSD" ON_ARCH "x86" "x64" "arm" "arm64" ON_CRT_LINKAGE "dynamic" "static" ON_LIBRARY_LINKAGE "dynamic" "static")

@JackBoosY
Copy link
Contributor

/azp run

JackBoosY
JackBoosY suggested changes Dec 6, 2019
View reviewed changes
@JackBoosY
Copy link
Contributor 

D:\buildtrees\marble\src\557137c282-91d5d9e5b5.clean\src\lib\marble\graphicsview\FrameGraphicsItem.cpp(240): error C2027: use of undefined type 'QPainterPath'
D:\installed\x64-windows\include\QtGui\qpainter.h(69): note: see declaration of 'QPainterPath'

@JackBoosY JackBoosY removed the category:new-port The issue is requesting a new library to be added; consider making a PR! label Jul 16, 2020
@JackBoosY JackBoosY requested a review from PhoebeHui July 16, 2020 07:03
@JackBoosY JackBoosY added category:new-port The issue is requesting a new library to be added; consider making a PR! and removed requires:author-response labels Jul 16, 2020
@PhoebeHui PhoebeHui added the info:reviewed Pull Request changes follow basic guidelines label Jul 20, 2020
@ig-or ig-or closed this Jul 20, 2020
@ig-or ig-or reopened this Jul 20, 2020
strega-nil
strega-nil suggested changes Jul 27, 2020
View reviewed changes
Copy link
Contributor

@strega-nil strega-nil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change in the Supports field

@strega-nil strega-nil self-requested a review July 27, 2020 18:26
@strega-nil
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ig-or
Copy link
Contributor Author

ig-or commented Jul 31, 2020

Can we merge it?

@JackBoosY
Copy link
Contributor

Yep, @strega-nil

@strega-nil strega-nil merged commit 8d09f42 into microsoft:master Jul 31, 2020
@ig-or
Copy link
Contributor Author

ig-or commented Aug 5, 2020

/azp run

hellozee pushed a commit to hellozee/vcpkg that referenced this pull request Sep 11, 2020
@ig-or @strega-nil @hellozee
[marble] Add new port (microsoft#8628)
9ed535f 
* KDE Marble library port

* fix in port KDE Marble library

* port KDE Marble library: switch to another version

* vcpkg_fail_port_install added (since only Windows currently supported)

* remove some comments

* Update portfile

* KDE Marble library port

* fix in port KDE Marble library

* port KDE Marble library: switch to another version

* vcpkg_fail_port_install added (since only Windows currently supported)

* remove some comments

* Update portfile

* small fix in KDE Marble library port

* removed ON_LIBRARY_LINKAGE static, and ANDROID FREEBSD

* [marble]Fix triplet judgment

* [kde] Add x64-windows-static state to baseline

* [marble] Re-add x64-windows-static state to baseline

* marble port changed

* marble profile.cmake small correction

* marble: another tiny changes in a port file

* marble: patch to move exe to tools

* [marble] patch for another QT version

* Update ports/marble/CONTROL

* move dll files to bin folder (out of tools folder)

Co-authored-by: Igor Sandler <isandler@topcon.com>
Co-authored-by: Phoebe <v-phma@microsoft.com>
Co-authored-by: JackBoosY <yuzaiyang@beyondsoft.com>
Co-authored-by: nicole mazzuca <mazzucan@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhoebeHui PhoebeHui PhoebeHui approved these changes

+3 more reviewers

@wrobelda wrobelda wrobelda left review comments

@JackBoosY JackBoosY JackBoosY approved these changes

@strega-nil strega-nil strega-nil approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@PhoebeHui PhoebeHui

@JackBoosY JackBoosY

@dan-shaw dan-shaw

Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[New Port Request] marble
7 participants
@ig-or @msftclas @JackBoosY @PhoebeHui @strega-nil @wrobelda @dan-shaw