Skip to content

[libp7-baical] Fix build error #13540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 21, 2020
Merged

[libp7-baical] Fix build error #13540

merged 2 commits into from
Oct 21, 2020

Conversation

NancyLi1013
Copy link
Contributor

Fix build error due to this:

CMake Error at scripts/cmake/vcpkg_extract_source_archive_ex.cmake:131 (message):
Could not unwrap top level directory from archive. Pass
NO_REMOVE_ONE_LEVEL to disable this.
Call Stack (most recent call first):
ports/libp7-baical/portfile.cmake:20 (vcpkg_extract_source_archive_ex)
scripts/ports.cmake:79 (include)

Note: No features need to test.

@NancyLi1013 NancyLi1013 added category:port-bug The issue is with a library, which is something the port should already support info:internal labels Sep 15, 2020
@NancyLi1013
Copy link
Contributor Author

Failed on osx due to this:

/Users/vagrant/Data/buildtrees/libp7-baical/src/libP7_v4-c47d6811c9.clean/Shared/Platforms/Linux_x86/PString.h:25:
/Users/vagrant/Data/buildtrees/libp7-baical/src/libP7_v4-c47d6811c9.clean/Shared/UTF.h:161:49: error: unknown type name 'tWCHAR'; did you mean 'tACHAR'?
                                                tWCHAR     *o_pDst, 
                                                ^~~~~~
                                                tACHAR
/Users/vagrant/Data/buildtrees/libp7-baical/src/libP7_v4-c47d6811c9.clean/Headers/GTypes.h:110:30: note: 'tACHAR' declared here
typedef char                 tACHAR;
                             ^
In file included from /Users/vagrant/Data/buildtrees/libp7-baical/src/libP7_v4-c47d6811c9.clean/Sources/Proxy.cpp:23:
In file included from /Users/vagrant/Data/buildtrees/libp7-baical/src/libP7_v4-c47d6811c9.clean/Sources/CommonClient.h:33:
In file included from /Users/vagrant/Data/buildtrees/libp7-baical/src/libP7_v4-c47d6811c9.clean/Sources/Common.h:39:
In file included from /Users/vagrant/Data/buildtrees/libp7-baical/src/libP7_v4-c47d6811c9.clean/Shared/Platforms/Linux_x86/PString.h:25:
/Users/vagrant/Data/buildtrees/libp7-baical/src/libP7_v4-c47d6811c9.clean/Shared/UTF.h:185:24: error: unknown type name 'tWCHAR'; did you mean 'tACHAR'?
            *o_pDst = (tWCHAR)l_bCh;
                       ^~~~~~
                       tACHAR
/Users/vagrant/Data/buildtrees/libp7-baical/src/libP7_v4-c47d6811c9.clean/Headers/GTypes.h:110:30: note: 'tACHAR' declared here
typedef char                 tACHAR;
                             ^
In file included from /Users/vagrant/Data/buildtrees/libp7-baical/src/libP7_v4-c47d6811c9.clean/Sources/Proxy.cpp:23:
In file included from /Users/vagrant/Data/buildtrees/libp7-baical/src/libP7_v4-c47d6811c9.clean/Sources/CommonClient.h:33:
In file included from /Users/vagrant/Data/buildtrees/libp7-baical/src/libP7_v4-c47d6811c9.clean/Sources/Common.h:39:
In file included from /Users/vagrant/Data/buildtrees/libp7-baical/src/libP7_v4-c47d6811c9.clean/Shared/Platforms/Linux_x86/PString.h:25:
/Users/vagrant/Data/buildtrees/libp7-baical/src/libP7_v4-c47d6811c9.clean/Shared/UTF.h:189:25: error: unknown type name 'tWCHAR'; did you mean 'tACHAR'?
            *o_pDst  = (tWCHAR)((l_bCh & 0x1F) << 6);
                        ^~~~~~
                        tACHAR
/Users/vagrant/Data/buildtrees/libp7-baical/src/libP7_v4-c47d6811c9.clean/Headers/GTypes.h:110:30: note: 'tACHAR' declared here
typedef char                 tACHAR;
                             ^
In file included from /Users/vagrant/Data/buildtrees/libp7-baical/src/libP7_v4-c47d6811c9.clean/Sources/Proxy.cpp:23:
In file included from /Users/vagrant/Data/buildtrees/libp7-baical/src/libP7_v4-c47d6811c9.clean/Sources/CommonClient.h:33:
In file included from /Users/vagrant/Data/buildtrees/libp7-baical/src/libP7_v4-c47d6811c9.clean/Sources/Common.h:39:
In file included from /Users/vagrant/Data/buildtrees/libp7-baical/src/libP7_v4-c47d6811c9.clean/Shared/Platforms/Linux_x86/PString.h:25:
/Users/vagrant/Data/buildtrees/libp7-baical/src/libP7_v4-c47d6811c9.clean/Shared/UTF.h:194:25: error: unknown type name 'tWCHAR'; did you mean 'tACHAR'?
            *o_pDst  = (tWCHAR)((l_bCh & 0xF) << 12);
                        ^~~~~~
                        tACHAR
/Users/vagrant/Data/buildtrees/libp7-baical/src/libP7_v4-c47d6811c9.clean/Headers/GTypes.h:110:30: note: 'tACHAR' declared here
typedef char                 tACHAR;
                             ^

After solving this problem, another error occurred:

/Users/vcpkg/Nancy/13540/vcpkg/buildtrees/libp7-baical/src/libP7_v4-c47d6811c9/Shared/Platforms/Linux_x86/PMEvent.h:385:18: error: use of undeclared iden    tifier 'sem_timedwait'
 51         if (0 == sem_timedwait(&m_sSem, &l_sTime))
 52                  ^

Seems sem_timedwait isn't available on osx.

So I decide to disable the support for osx now.

@NancyLi1013 NancyLi1013 requested a review from LilyWangL October 21, 2020 01:48
@LilyWangL LilyWangL added the info:reviewed Pull Request changes follow basic guidelines label Oct 21, 2020
@BillyONeal
Copy link
Member

Thanks for your contribution!

@BillyONeal BillyONeal merged commit 3df2c00 into microsoft:master Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@LilyWangL LilyWangL LilyWangL approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@LilyWangL LilyWangL

Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[libp7-baical[core]:x86-windows] build failure
3 participants
@NancyLi1013 @BillyONeal @LilyWangL