Skip to content

[nng] Update to 1.3.2 #13545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 24, 2020
Merged

[nng] Update to 1.3.2 #13545

merged 3 commits into from
Sep 24, 2020

Conversation

myd7349
Copy link
Contributor

@myd7349 myd7349 commented Sep 15, 2020

Describe the pull request

  • What does your PR fix?
    Update nng to 1.3.2 (bug fixes).

  • Which triplets are supported/not supported? Have you updated the CI baseline?
    N/A. No.

  • Does your PR follow the maintainer guide?
    Yes

@myd7349
[nng] Update to 1.3.2
22d7c25 
[nng] Add tools feature
NancyLi1013
NancyLi1013 reviewed Sep 16, 2020
View reviewed changes
@NancyLi1013 NancyLi1013 added category:port-update The issue is with a library, which is requesting update new revision requires:author-response labels Sep 16, 2020
@myd7349 myd7349 marked this pull request as ready for review September 17, 2020 00:33
@NancyLi1013
Copy link
Contributor

Looks work fine now.
Have you tested these features in this PR?

@myd7349
Copy link
Contributor Author

myd7349 commented Sep 17, 2020

Looks work fine now.
Have you tested these features in this PR?

Yes.

@NancyLi1013 NancyLi1013 added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Sep 17, 2020
ras0219-msft
ras0219-msft requested changes Sep 21, 2020
View reviewed changes
Copy link
Collaborator

@ras0219-msft ras0219-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once my comment is addressed. Thanks for the PR!

@NancyLi1013 @ras0219-msft
Update ports/nng/portfile.cmake
63f0195 
Co-authored-by: Robert Schumacher <roschuma@microsoft.com>
@ras0219-msft ras0219-msft merged commit c6fbdb0 into microsoft:master Sep 24, 2020
@ras0219-msft
Copy link
Collaborator

Thanks for the PR!

@myd7349 myd7349 deleted the nng-1.3.2 branch September 25, 2020 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ras0219-msft ras0219-msft ras0219-msft requested changes

+1 more reviewer

@NancyLi1013 NancyLi1013 NancyLi1013 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@NancyLi1013 NancyLi1013

Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@myd7349 @NancyLi1013 @ras0219-msft