Skip to content

[libsigcpp-3] Add new port #13412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 7, 2020
Merged

[libsigcpp-3] Add new port #13412

merged 8 commits into from
Oct 7, 2020

Conversation

brukted
Copy link
Contributor

@brukted brukted commented Sep 8, 2020 •
edited by LilyWangL
Loading

Submission containing materials of a third party: The libsigc++ Development Team under GPL-3.0 License

@LilyWangL LilyWangL added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Sep 9, 2020
@LilyWangL LilyWangL added the info:reviewed Pull Request changes follow basic guidelines label Sep 9, 2020
@brukted brukted requested a review from LilyWangL September 9, 2020 10:54
ras0219-msft
ras0219-msft requested changes Sep 9, 2020
View reviewed changes
Copy link
Collaborator

@ras0219-msft ras0219-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! Looks good to me once these comments are addressed.

@LilyWangL LilyWangL removed the info:reviewed Pull Request changes follow basic guidelines label Sep 10, 2020
@LilyWangL
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@brukted
Copy link
Contributor Author

brukted commented Sep 28, 2020

@LilyWangL @ras0219-msft I think this pr is ready to merge.

@LilyWangL LilyWangL added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Sep 29, 2020
@BillyONeal BillyONeal merged commit 59a20fb into microsoft:master Oct 7, 2020
@BillyONeal
Copy link
Member

Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LilyWangL LilyWangL Awaiting requested review from LilyWangL

@ras0219-msft ras0219-msft Awaiting requested review from ras0219-msft

Assignees

@LilyWangL LilyWangL

Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[New Port Request] libsigcpp-3
4 participants
@brukted @LilyWangL @BillyONeal @ras0219-msft