Skip to content

Conversation

AenBleidd
Copy link
Contributor

Signed-off-by: Vitalii Koshura lestat.de.lionkur@gmail.com

Signed-off-by: Vitalii Koshura <lestat.de.lionkur@gmail.com>
@JackBoosY JackBoosY added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Sep 3, 2020
Signed-off-by: Vitalii Koshura <lestat.de.lionkur@gmail.com>
@AenBleidd
Copy link
Contributor Author

@JackBoosY, @strega-nil, @BillyONeal, all comments are fixed. Please make review again. Thanks in advance

Signed-off-by: Vitalii Koshura <lestat.de.lionkur@gmail.com>
@AenBleidd
Copy link
Contributor Author

@JackBoosY, all comments are fixed

@AenBleidd AenBleidd requested a review from JackBoosY September 4, 2020 09:20
Copy link
Contributor

@strega-nil strega-nil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good! I think just the export names need to change, so that someone can find this library via find_package :)

Signed-off-by: Vitalii Koshura <lestat.de.lionkur@gmail.com>
@BillyONeal BillyONeal merged commit 2e110d2 into microsoft:master Sep 5, 2020
@BillyONeal
Copy link
Member

Thanks for your contribution!

@AenBleidd AenBleidd deleted the vko_add_port_rappture branch September 5, 2020 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants