Skip to content

[log4cpp] Fix header file install path #12792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 7, 2020
Merged

[log4cpp] Fix header file install path #12792

merged 1 commit into from
Aug 7, 2020

Conversation

LilyWangL
Copy link
Contributor

Describe the pull request

  • What does your PR fix? Fixes [log4cpp] generates additional annoying subdirectory oros #12646
    Modifying log4cpp header file install path to fix error:
    vcpkg\installed\x64-windows\include\orocos\log4cpp\Appender.hh(13,10): fatal error C1083: Datei (Include) kann nicht geöffnet werden: "log4cpp/Portability.hh": No such file or directory
  • Which triplets are supported/not supported? Have you updated the CI baseline?
    Yes
  • Does your PR follow the maintainer guide?
    Yes

@LilyWangL LilyWangL added category:port-bug The issue is with a library, which is something the port should already support info:internal labels Aug 7, 2020
@NancyLi1013 NancyLi1013 marked this pull request as ready for review August 7, 2020 06:57
@NancyLi1013 NancyLi1013 added the info:reviewed Pull Request changes follow basic guidelines label Aug 7, 2020
@strega-nil strega-nil merged commit 5a9c8fb into microsoft:master Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@NancyLi1013 NancyLi1013 NancyLi1013 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@NancyLi1013 NancyLi1013

Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[log4cpp] generates additional annoying subdirectory oros
3 participants
@LilyWangL @NancyLi1013 @strega-nil