[boost] Add Supports fields and more accurately handle arm64-windows/x64-uwp #12762
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhoebeHui
reviewed
Aug 6, 2020
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
PhoebeHui
approved these changes
Aug 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
Supportsfields to the boost suite such thatboost:arm64-windows,boost:x64-uwpandboost:arm64-uwpare all now installable.This PR may introduce undesirable behavior for certain unofficial platform combinations (native compilation on
arm64-linuxfor example), however we have no way to effectively test these systems as they are unofficial.What does your PR fix?
Fixes [boost-coroutine:arm-windows] build failure #12304, boost --triplet x64-uwp build failure #10609, Building boost for ARM64 UPW fails #6095.
Which triplets are supported/not supported? Have you updated the CI baseline?
All official triplets have been handled, Yes
Does your PR follow the maintainer guide?
Yes