Skip to content

[qwtw] Add new port #12748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 7, 2020
Merged

[qwtw] Add new port #12748

merged 6 commits into from
Aug 7, 2020

Conversation

ig-or
Copy link
Contributor

@ig-or ig-or commented Aug 4, 2020

add another library port (qwtw)

only Windows x64bit non-static is currently supported. Will try to eventually add Linux.
CI baseline updated.

@ig-or
Copy link
Contributor Author

ig-or commented Aug 4, 2020

it tells "Error code: 1
2020-08-04T21:03:20.3877860Z See logs for more information:
2020-08-04T21:03:20.3883198Z D:\buildtrees\qwtw\config-x64-windows-out.log"

how to get to the actual log file with more information?

@LilyWangL LilyWangL changed the title Qwtw port [qwtw] Add new port Aug 5, 2020
@LilyWangL
Copy link
Contributor

LilyWangL commented Aug 5, 2020 •
edited
Loading

@ig-or Thanks for your PR. qwtw:x64-windows build failed with the following error:

CMake Error at D:/downloads/tools/cmake-3.17.2-windows/cmake-3.17.2-win32-x86/share/cmake-3.17/Modules/FindPackageHandleStandardArgs.cmake:164 (message):
  Could NOT find Boost (missing: thread) (found version "1.73.0")
Call Stack (most recent call first):
  D:/downloads/tools/cmake-3.17.2-windows/cmake-3.17.2-win32-x86/share/cmake-3.17/Modules/FindPackageHandleStandardArgs.cmake:445 (_FPHSA_FAILURE_MESSAGE)
  D:/downloads/tools/cmake-3.17.2-windows/cmake-3.17.2-win32-x86/share/cmake-3.17/Modules/FindBoost.cmake:2162 (find_package_handle_standard_args)
  C:/agent/_work/1/s/scripts/buildsystems/vcpkg.cmake:419 (_find_package)
  buildsys/ccmake.cmake:157 (find_package)
  buildsys/ccmake.cmake:924 (addBoost)
  buildsys/ccmake.cmake:1033 (commonEnd)
  qwtw/c_lib/CMakeLists.txt:112 (libraryEnd)

You can download the error log from this URL: https://dev.azure.com/vcpkg/c1ee48cb-0df2-4ab3-8384-b1df5a79fe53/_apis/build/builds/41073/artifacts?artifactName=x64-windows%20port%20build%20failure%20logs&api-version=5.1&%24format=zip
And you have added supports in CONTROL, so you need not add information to ci.baseline.txt.

@LilyWangL LilyWangL added category:new-port The issue is requesting a new library to be added; consider making a PR! requires:author-response labels Aug 5, 2020
@ig-or
Copy link
Contributor Author

ig-or commented Aug 5, 2020

LilyWangL, thank you very much. Will try to fix it.

@ig-or
Copy link
Contributor Author

ig-or commented Aug 6, 2020

@LilyWangL , would you please review?

@LilyWangL LilyWangL added the info:reviewed Pull Request changes follow basic guidelines label Aug 7, 2020
@strega-nil
Copy link
Contributor

Cool, thanks @ig-or :)

@strega-nil strega-nil merged commit 5b35ffe into microsoft:master Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@LilyWangL LilyWangL LilyWangL approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@LilyWangL LilyWangL

Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ig-or @LilyWangL @strega-nil