Skip to content

[secp256k1] Fix build failures and export cmake targets #12630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 7, 2020
Merged

[secp256k1] Fix build failures and export cmake targets #12630

merged 2 commits into from
Aug 7, 2020

Conversation

PhoebeHui
Copy link
Contributor

Fixes #12622

  1. Add missing include path
  2. Export the cmake targets
  3. Remove secp256k1:x64-linux=fail and secp256k1:x64-osx=fail in ci baseline file.

@PhoebeHui PhoebeHui added category:port-bug The issue is with a library, which is something the port should already support info:internal labels Jul 29, 2020
@JackBoosY JackBoosY changed the title [secp256k1 Fix build failures and export cmake targets [secp256k1] Fix build failures and export cmake targets Jul 30, 2020
@PhoebeHui PhoebeHui marked this pull request as ready for review August 6, 2020 02:47
@PhoebeHui PhoebeHui added the info:reviewed Pull Request changes follow basic guidelines label Aug 7, 2020
@strega-nil strega-nil merged commit 3ca402b into microsoft:master Aug 7, 2020
@PhoebeHui PhoebeHui deleted the dev/Phoebe/secp256k1 branch August 11, 2020 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@JackBoosY JackBoosY JackBoosY approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@JackBoosY JackBoosY

Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[secp256k1 build failure due to missing include path
3 participants
@PhoebeHui @JackBoosY @strega-nil