Skip to content

[pangolin] Fix build failure on UNIX #12515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Aug 7, 2020
Merged

[pangolin] Fix build failure on UNIX #12515

merged 8 commits into from
Aug 7, 2020

Conversation

JackBoosY
Copy link
Contributor

@JackBoosY JackBoosY commented Jul 21, 2020 •
edited
Loading

Finding ffmpeg components in Pangolin's built-in FindFFmpeg.cmake is not complete, which causes the build failure in UNIX.

Fixes #10099

Thanks @Wkkkkk!

@JackBoosY JackBoosY added category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:internal labels Jul 21, 2020
@JackBoosY JackBoosY changed the title Dev/jack/10099 [pangolin] Fix build failure on UNIX Jul 21, 2020
PhoebeHui
PhoebeHui requested changes Jul 23, 2020
View reviewed changes
@JackBoosY JackBoosY marked this pull request as ready for review July 23, 2020 09:44
@JackBoosY JackBoosY requested a review from PhoebeHui July 23, 2020 09:44
@PhoebeHui PhoebeHui marked this pull request as draft July 24, 2020 01:50
@JackBoosY JackBoosY marked this pull request as ready for review August 3, 2020 05:35
@PhoebeHui PhoebeHui added the info:reviewed Pull Request changes follow basic guidelines label Aug 5, 2020
strega-nil
strega-nil suggested changes Aug 5, 2020
View reviewed changes
Copy link
Contributor

@strega-nil strega-nil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's the only thing I see.

@JackBoosY @strega-nil
Update ports/pangolin/CONTROL
41e598b 
Co-authored-by: nicole mazzuca <mazzucan@outlook.com>
@strega-nil
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@strega-nil strega-nil merged commit accd1c8 into microsoft:master Aug 7, 2020
@JackBoosY JackBoosY deleted the dev/jack/10099 branch August 7, 2020 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhoebeHui PhoebeHui PhoebeHui approved these changes

+1 more reviewer

@strega-nil strega-nil strega-nil requested changes

Reviewers whose approvals may not affect merge requirements
Assignees

@PhoebeHui PhoebeHui

Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[pangolin] build failure
3 participants
@JackBoosY @strega-nil @PhoebeHui