Skip to content

[libb2] Add supports and install pkg-conifg on macOS VM #12398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 14, 2020
Merged

[libb2] Add supports and install pkg-conifg on macOS VM #12398

merged 4 commits into from
Jul 14, 2020

Conversation

PhoebeHui
Copy link
Contributor

Related to #12254

  1. Move CONTROL to vcpkg,json
  2. Add supports
  3. Install pkg-config in MacOS VM for fixing below error:
Makefile.am:7: error: 'pkgconfig_DATA' is used but 'pkgconfigdir' is undefined
src/Makefile.am: installing './depcomp'
parallel-tests: installing './test-driver'
autoreconf: automake failed with exit status: 1

@PhoebeHui PhoebeHui added category:port-bug The issue is with a library, which is something the port should already support info:internal depends:vm-update PR contains changes to the VM provisioning scripts labels Jul 13, 2020
@PhoebeHui PhoebeHui marked this pull request as ready for review July 13, 2020 06:38
@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Jul 13, 2020
@JackBoosY JackBoosY requested a review from BillyONeal July 13, 2020 09:19
@PhoebeHui PhoebeHui mentioned this pull request Jul 13, 2020
Merged
BillyONeal
BillyONeal reviewed Jul 13, 2020
View reviewed changes
@ras0219-msft ras0219-msft merged commit 9891a8f into microsoft:master Jul 14, 2020
@PhoebeHui PhoebeHui deleted the dev/Phoebe/libb2 branch August 11, 2020 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillyONeal BillyONeal BillyONeal approved these changes

+1 more reviewer

@JackBoosY JackBoosY JackBoosY approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@JackBoosY JackBoosY

Labels
category:port-bug The issue is with a library, which is something the port should already support depends:vm-update PR contains changes to the VM provisioning scripts info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@PhoebeHui @BillyONeal @JackBoosY @ras0219-msft