Skip to content

Conversation

Squareys
Copy link
Contributor

@Squareys Squareys commented Jul 2, 2020

Hi all!

This PR fixes some platform-specific features issues and updates all ports to the very recent 2020.06 release of the magnum family of ports!

As always @mosra will have a quick review and approve.

Best,
Jonathan

@Squareys Squareys force-pushed the update-magnum-ports branch from 0311c3a to 8c842b2 Compare July 2, 2020 14:19
@mosra mosra mentioned this pull request Jul 2, 2020
87 tasks
@JackBoosY JackBoosY added category:documentation To resolve the issue, documentation will need to be updated category:port-update The issue is with a library, which is requesting update new revision labels Jul 3, 2020
@Squareys Squareys force-pushed the update-magnum-ports branch from 138f473 to 2f44089 Compare July 7, 2020 08:03
Squareys added 11 commits July 7, 2020 10:51
Allows `vcpkg install magnum[*]` on any platform.

Signed-off-by: Squareys <squareys@googlemail.com>
Signed-off-by: Squareys <squareys@googlemail.com>
Signed-off-by: Squareys <squareys@googlemail.com>
Signed-off-by: Squareys <squareys@googlemail.com>
Analog to magnum port.

Signed-off-by: Squareys <squareys@googlemail.com>
Signed-off-by: Squareys <squareys@googlemail.com>
Signed-off-by: Squareys <squareys@googlemail.com>
Signed-off-by: Squareys <squareys@googlemail.com>
Signed-off-by: Squareys <squareys@googlemail.com>
@Squareys Squareys force-pushed the update-magnum-ports branch from 2f44089 to 0111995 Compare July 7, 2020 08:51
@Squareys
Copy link
Contributor Author

Squareys commented Jul 7, 2020

@LilyWangL @ras0219 Thank you for your reviews! 🙏

I applied all the requested changes.

@LilyWangL LilyWangL added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Jul 7, 2020
@Squareys Squareys requested a review from LilyWangL July 12, 2020 10:34
@ras0219-msft ras0219-msft merged commit 5e40afc into microsoft:master Jul 14, 2020
@ras0219-msft
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:documentation To resolve the issue, documentation will need to be updated category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants