Skip to content

Conversation

DragonJoker
Copy link
Contributor

@DragonJoker DragonJoker commented Oct 16, 2020

Describe the pull request

  • What does your PR fix?
    Fixes [New Port Request] ashes #13893 .

  • Which triplets are supported/not supported? Have you updated the CI baseline?
    UWP, iOS and Android are not supported. x86 and arm platforms are unsupported.
    I have tested x64-windows, x64-linux and x64-osx, and Ashes doesn't support static library linkage.
    The CI baseline has been updated.

  • Does your PR follow the maintainer guide?
    Yes.

@ghost
Copy link

ghost commented Oct 16, 2020

CLA assistant check
All CLA requirements met.

@LilyWangL LilyWangL added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Oct 19, 2020
@LilyWangL LilyWangL added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Oct 22, 2020
@BillyONeal BillyONeal merged commit 3048968 into microsoft:master Oct 23, 2020
@BillyONeal
Copy link
Member

Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Port Request] ashes
3 participants