Skip to content

Conversation

makinori
Copy link
Contributor

  • What does your PR fix?

    Adds libspnav from https://github.com/FreeSpacenav/libspnav which is for SpaceMouse support. Blender uses this same library for example.

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    Just Linux. I was able to install through vcpkg with x64 and arm64. X11 was necessary to compile. Both VCPKG_BUILD_TYPE and VCPKG_LIBRARY_LINKAGE are respected. I haven't touched the CI baseline.

  • Does your PR follow the maintainer guide?

    Yes, I think so.

@makinori makinori changed the title libspnav [libspnav] Add new port Oct 14, 2020
@NancyLi1013 NancyLi1013 added category:new-port The issue is requesting a new library to be added; consider making a PR! requires:author-response labels Oct 15, 2020
@makinori
Copy link
Contributor Author

Thank you so much, PhoebeHui, Hoikas and NancyLi for helping! I applied your requested changes.

@makinori
Copy link
Contributor Author

If it's possible, can I try compiling and testing this on macOS tomorrow? (since it's 04:31 am here) I can then confirm if that works or not.

@NancyLi1013
Copy link
Contributor

NancyLi1013 commented Oct 15, 2020

If it's possible, can I try compiling and testing this on macOS tomorrow? (since it's 04:31 am here) I can then confirm if that works or not.

Of course, you can do this at any time available for you. It's too late for you now. Please have a good rest first. You can update it tomorrow if it can support osx.

@makinori
Copy link
Contributor Author

Of course, you can do this at any time available for you. It's too late for you now. Please have a good rest first. You can update it tomorrow if it can support osx.

I looked further into this and tried to compile it, and I'm sure it would make no sense to support macOS. This library was never intended to work for Mac since you need to use a user-space driver thats only available for Linux. On top of that, there's no X11 support for Mac anymore which is required (It's XQuartz now for quite some time). The commit was from 2013. I think Blender uses the proprietary driver on Windows and Mac and libspnav on Linux.

I'm happy with the port! The only suggestion I could think of is maybe adding a comment explaining the confusion between ref v0.2.3 and libspnav-0.2.3

@NancyLi1013
Copy link
Contributor

Thanks for your further investigation about this new port. It's so great.
I agree with your point that adding a comment to explain the ref.

@NancyLi1013 NancyLi1013 added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Oct 19, 2020
@BillyONeal BillyONeal merged commit 3100690 into microsoft:master Oct 20, 2020
@BillyONeal
Copy link
Member

Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants