[rel/4.0]: Unify TestSessionContext #6344
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdb17b5 to
9e6b680
Compare
Youssef1313
commented
Aug 11, 2025
| @@ -5,9 +5,24 @@ | |||
|
|
|||
| namespace Microsoft.Testing.Platform.Services; | |||
|
|
|||
| internal sealed class TestSessionContext(CancellationToken cancellationToken) : ITestSessionContext | |||
There was a problem hiding this comment.
NOTE: Previously this was internal (in Services namespace), and another public TestSessionContext was in TestHost namespace.
I'm not really sure if it makes more sense to expose in Services namespace or TestHost namespace.
The notable public APIs with TestSessionContext in signature is TestExecutionRequest.Session (well, the property name isn't super good IMO but that's a different discussion). The TestExecutionRequest is kinda testhost-specific I think.
0de95f5 to
3d5fce7
Compare
3d5fce7 to
a5515c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #5762