Skip to content

Avoid using records for public APIs #6030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jul 17, 2025
Merged

Avoid using records for public APIs #6030

merged 12 commits into from
Jul 17, 2025

Conversation

Youssef1313
Copy link
Member

@Youssef1313 Youssef1313 commented Jul 15, 2025 •
edited
Loading

Related to #5762

Closes #5517

@Youssef1313 Youssef1313 added this to the Platform 2.0 milestone Jul 15, 2025
@Youssef1313 Youssef1313 linked an issue Jul 15, 2025 that may be closed by this pull request
[MTP v2][Breaking] Avoid the use of C# records in public API #5517
Closed
@Youssef1313 Youssef1313 force-pushed the dev/ygerges/avoid-public-records branch 2 times, most recently from 5f1eaf8 to 11090d4 Compare July 15, 2025 12:17
Evangelink
Evangelink reviewed Jul 15, 2025
View reviewed changes
Copy link
Member

@Evangelink Evangelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should implement a custom ToString for all these types so the logs remain useful.

@Youssef1313 Youssef1313 force-pushed the dev/ygerges/avoid-public-records branch 2 times, most recently from a8065b9 to 4dbad86 Compare July 15, 2025 12:24
@Youssef1313 Youssef1313 force-pushed the dev/ygerges/avoid-public-records branch from 952724a to d84b7ea Compare July 16, 2025 08:07
@Youssef1313 Youssef1313 merged commit 5135940 into rel/4.0 Jul 17, 2025
8 checks passed
@Youssef1313 Youssef1313 deleted the dev/ygerges/avoid-public-records branch July 17, 2025 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Evangelink Evangelink Evangelink left review comments

@nohwnd nohwnd nohwnd approved these changes

Assignees
No one assigned
Labels
Breaking ‼️
Projects
None yet
Milestone
Platform 2.0
Development

Successfully merging this pull request may close these issues.

[MTP v2][Breaking] Avoid the use of C# records in public API
3 participants
@Youssef1313 @nohwnd @Evangelink