Skip to content

Conversation

Youssef1313
Copy link
Member

Closes #5645

Related to #1285

@Youssef1313 Youssef1313 added this to the 4.0.0 milestone Jun 25, 2025
@Romfos
Copy link

Romfos commented Jun 25, 2025

Make sense also drop it everywhere. Anyway you cannot run tests for NS. You must use platform TFM

@Youssef1313
Copy link
Member Author

@Romfos It's too aggressive to drop it from TestFramework IMO. You can have a test utilities library that target netstandard2.0 that you then reference in your test projects. For adapter, the story is different, because adapter isn't intended to be used in test utility libraries and is only intended to be used in actual test projects that shouldn't target netstandard2.0.

@Youssef1313 Youssef1313 requested a review from Evangelink June 26, 2025 08:48
@Youssef1313
Copy link
Member Author

We are not correctly testing .NET Framework of adapter in some cases, e.g, FileOperationTests. We wrap the whole class in #if !NET462, so we test only with .NET Framework 4.8. However, we use the netstandard2.0 assembly of the adapter in this case.

@codecov-commenter
Copy link

codecov-commenter commented Jun 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.82%. Comparing base (f7f69d6) to head (c3724ea).
Report is 12 commits behind head on dev/v4.

Additional details and impacted files
@@            Coverage Diff             @@
##           dev/v4    #5882      +/-   ##
==========================================
+ Coverage   63.09%   65.82%   +2.73%     
==========================================
  Files         574      574              
  Lines       31434    31453      +19     
==========================================
+ Hits        19833    20705     +872     
+ Misses      11601    10748     -853     
Flag Coverage Δ
Debug 65.82% <ø> (+2.73%) ⬆️
integration 65.84% <ø> (+2.74%) ⬆️
production 65.82% <ø> (+2.73%) ⬆️
unit 65.86% <ø> (+2.77%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 66 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Youssef1313 Youssef1313 requested a review from Evangelink June 27, 2025 11:57
@Evangelink Evangelink merged commit 71f0813 into dev/v4 Jun 27, 2025
8 checks passed
@Evangelink Evangelink deleted the dev/ygerges/netstandard branch June 27, 2025 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Breaking][v4] MSTest.TestAdapter (and consequently MSTest metapackage) should drop netstandard2.0
4 participants