-
Notifications
You must be signed in to change notification settings - Fork 285
Drop netstandard2.0 from adapter #5882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Make sense also drop it everywhere. Anyway you cannot run tests for NS. You must use platform TFM |
@Romfos It's too aggressive to drop it from TestFramework IMO. You can have a test utilities library that target netstandard2.0 that you then reference in your test projects. For adapter, the story is different, because adapter isn't intended to be used in test utility libraries and is only intended to be used in actual test projects that shouldn't target netstandard2.0. |
We are not correctly testing .NET Framework of adapter in some cases, e.g, FileOperationTests. We wrap the whole class in |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev/v4 #5882 +/- ##
==========================================
+ Coverage 63.09% 65.82% +2.73%
==========================================
Files 574 574
Lines 31434 31453 +19
==========================================
+ Hits 19833 20705 +872
+ Misses 11601 10748 -853
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
test/UnitTests/MSTestAdapter.PlatformServices.UnitTests/Services/FileOperationsTests.cs
Outdated
Show resolved
Hide resolved
test/UnitTests/MSTest.Engine.UnitTests/MSTest.Engine.UnitTests.csproj
Outdated
Show resolved
Hide resolved
…es/FileOperationsTests.cs
Closes #5645
Related to #1285