Skip to content

Drop unsupported TFMs #5852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 29 commits into from
Jun 25, 2025
Merged

Drop unsupported TFMs #5852

merged 29 commits into from
Jun 25, 2025

Conversation

Youssef1313
Copy link
Member

@Youssef1313 Youssef1313 commented Jun 22, 2025 •
edited
Loading

The MSTest part of #5614

Related to #1285

@Youssef1313 Youssef1313 force-pushed the dev/ygerges/unsupported-tfms branch from f0b4e47 to 5deab60 Compare June 23, 2025 06:14
Evangelink
Evangelink approved these changes Jun 23, 2025
View reviewed changes
Copy link
Member

@Evangelink Evangelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

Evangelink
Evangelink reviewed Jun 23, 2025
View reviewed changes
Evangelink
Evangelink reviewed Jun 23, 2025
View reviewed changes
@Youssef1313
Copy link
Member Author

Youssef1313 commented Jun 24, 2025 •
edited
Loading

@Sergio0694 I'm getting:

D:\a_work\1\s.dotnet\sdk\10.0.100-preview.6.25309.101\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.targets(305,5): error NETSDK1206: Found version-specific or distribution-specific runtime identifier(s): win10-arm64, win10-x64, win10-x86. Affected libraries: Microsoft.WindowsAppSDK. In .NET 8.0 and higher, assets for version-specific and distribution-specific runtime identifiers will not be found by default. See https://aka.ms/dotnet/rid-usage for details. [D:\a_work\1\s\src\TestFramework\TestFramework.Extensions\TestFramework.Extensions.csproj]

However, RuntimeIdentifiers is set to win-x86;win-x64;win-arm64:

image

I can't see where the win10-<arch> come from

Evangelink
Evangelink reviewed Jun 24, 2025
View reviewed changes
@Sergio0694
Copy link
Member

@Youssef1313 mmh that's weird. Do you not see win10- anywhere in the binlog? 🤔
Can you try to narrow it down and eg. only build/publish with UWP .NET 9 and WinUI 3 separately?

@Youssef1313
Copy link
Member Author

@Youssef1313 mmh that's weird. Do you not see win10- anywhere in the binlog? 🤔 Can you try to narrow it down and eg. only build/publish with UWP .NET 9 and WinUI 3 separately?

Fixed it by updating Microsoft.WinAppSDK to 1.6. We were on 1.0.0 which appear to be not supporting the win-<arch> well.

@Sergio0694
Copy link
Member

Ah, yeah that makes sense, we only fixed that one recently 🙂

@Youssef1313 Youssef1313 added this to the 4.0.0 milestone Jun 25, 2025
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.08%. Comparing base (b0d8589) to head (d4a179d).
Report is 10 commits behind head on dev/v4.

Additional details and impacted files 
@@            Coverage Diff             @@
##           dev/v4    #5852      +/-   ##
==========================================
- Coverage   65.87%   63.08%   -2.80%     
==========================================
  Files         574      574              
  Lines       31461    31453       -8     
==========================================
- Hits        20726    19841     -885     
- Misses      10735    11612     +877
Flag Coverage Δ
Debug 63.08% <100.00%> (-2.80%) ⬇️
integration 63.09% <100.00%> (-2.80%) ⬇️
production 63.08% <100.00%> (-2.80%) ⬇️
unit 63.11% <100.00%> (-2.80%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
....Analyzers/ClassInitializeShouldBeValidAnalyzer.cs 95.55% <100.00%> (ø)
...s/MSTest.Analyzers/DataRowShouldBeValidAnalyzer.cs 86.95% <100.00%> (ø)
...Test.Analyzers/DynamicDataShouldBeValidAnalyzer.cs 93.83% <100.00%> (ø)
...rs/NonNullableReferenceNotInitializedSuppressor.cs 84.61% <100.00%> (ø)
...MSTest.Analyzers/TestClassShouldBeValidAnalyzer.cs 94.66% <100.00%> (ø)
...Analyzers/TestClassShouldHaveTestMethodAnalyzer.cs 98.55% <100.00%> (ø)
...Test.Analyzers/TestCleanupShouldBeValidAnalyzer.cs 100.00% <100.00%> (ø)
...t.Analyzers/TestInitializeShouldBeValidAnalyzer.cs 100.00% <100.00%> (ø)
....Analyzers/TestMethodShouldNotBeIgnoredAnalyzer.cs 100.00% <100.00%> (ø)
...yzers/UseAsyncSuffixTestFixtureMethodSuppressor.cs 88.23% <100.00%> (ø)
... and 4 more

... and 66 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Youssef1313 Youssef1313 merged commit f7f69d6 into dev/v4 Jun 25, 2025
9 checks passed
@Youssef1313 Youssef1313 deleted the dev/ygerges/unsupported-tfms branch June 25, 2025 10:21
@Youssef1313 Youssef1313 linked an issue Jun 25, 2025 that may be closed by this pull request
Drop support for < net8.0 in MSTest and MTP #5614
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Evangelink Evangelink Evangelink approved these changes

+1 more reviewer

@Sergio0694 Sergio0694 Sergio0694 left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Breaking ‼️
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

Drop support for < net8.0 in MSTest and MTP
4 participants
@Youssef1313 @Sergio0694 @codecov-commenter @Evangelink