-
Notifications
You must be signed in to change notification settings - Fork 285
Remove CssIteration, CssProjectStructure, and Description #5858
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@Youssef1313, @Evangelink, we actually heavily use description attributes to provide detailed information about the tests. |
Thanks for the comment @avivanoff . Does it appear somewhere? If so then it might be worth for us switching to picking up the attribute from System Component Model |
@Evangelink, at a minimum it is part of TRX schema, see |
@avivanoff Thanks for bringing this up. It's indeed specified in the TRX schema, but it seems like VSTest never included this info in TRX before? There was a feature request here microsoft/vstest#98 but it was closed and not implemented. So far, I don't see anything we are losing with the removal of the attribute. To me, this sounds like it will be a new feature to implement on MTP TrxReport, and support it in MSTest and VSTestBridge. And then we can reuse System.ComponentModel.DescriptionAttribute. |
@Youssef1313, I really see a value in the attribute. How else would you specify what unit test does? We have tens of thousands of unit tests that use description attribute. We would have to touch thousands of files when upgrading to MSTest 4. If I am reading you right, we should switch to System.ComponentModel.DescriptionAttribute and file a feature request to support it. |
To make it easier, you can add a global using for
Yes. I think |
@Youssef1313, not everyone is lucky enough to be on C# 10 or later, our products still support .NET Framework 4.8. |
You can set |
@nohwnd You meant latest not default? |
I did not. However I too find that naming confusing. Docs say that using And that |
(and we do use Latest in our projects, with mostly success, but we also might be more used to having our projects not build after update, and that might not be what OP wants) |
@nohwnd, everything I find online about using LangVersion=default warns that it might lead to runtime errors. |
do you have some examples? :) From experience we do use Latest in our projects (which should be even more dangerous). And I only rarely get errors on my computer that others don't get. But I also install lot of random latest builds of .net 10, and so on. Default should be safer than Latest. But it is your project of course, so you do you. I just don't think it is necessary to limit yourself to the version of C# that comes with the TFM by default. If my anecdotal evidence is not enough, here is Mads telling you to do what the docs tell you to not do... |
We do not have the luxury to rely on YouTube videos, we need a clear statement in Microsoft's documentation. Anyways, this conversation went off track. My point was that removal/replacement of these attributes should be done properly via deprecation first. |
@avivanoff We will add back |
Can you please tell me where the documentation says that you should not use |
@nohwnd, see https://learn.microsoft.com/en-us/dotnet/csharp/language-reference/configure-language-version#c-language-version-reference:
|
Closes #5787
Related to #1285