Skip to content

Add lifecycle callbacks to test host orchestrator #5717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jun 12, 2025
Merged

Add lifecycle callbacks to test host orchestrator #5717

merged 9 commits into from
Jun 12, 2025

Conversation

Youssef1313
Copy link
Member

@Youssef1313 Youssef1313 commented Jun 9, 2025 •
edited
Loading

Fixes #5292

@Youssef1313 Youssef1313 marked this pull request as draft June 9, 2025 16:56
@Youssef1313 Youssef1313 force-pushed the dev/ygerges/retry-dotnet-test branch 5 times, most recently from 5efee6c to 9bfcbf7 Compare June 10, 2025 08:42
@codecov-commenter
Copy link

codecov-commenter commented Jun 10, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 58.82353% with 14 lines in your changes missing coverage. Please review.

Project coverage is 73.75%. Comparing base (97ee44f) to head (4a42a65).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
....Testing.Platform/Hosts/TestHostOchestratorHost.cs 22.22% 7 Missing ⚠️
...stHostOrcherstrator/TestHostOrchestratorManager.cs 68.18% 7 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5717      +/-   ##
==========================================
- Coverage   76.20%   73.75%   -2.46%     
==========================================
  Files         602      602              
  Lines       36707    36741      +34     
==========================================
- Hits        27973    27097     -876     
- Misses       8734     9644     +910
Flag Coverage Δ
Debug 73.75% <58.82%> (-2.46%) ⬇️
integration 73.75% <58.82%> (-2.46%) ⬇️
production 73.75% <58.82%> (-2.46%) ⬇️
unit 73.75% <58.82%> (-2.46%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...latform.MSBuild/Tasks/InvokeTestingPlatformTask.cs 0.00% <ø> (-59.11%) ⬇️
...icrosoft.Testing.Platform/Hosts/TestHostBuilder.cs 91.47% <100.00%> (-3.30%) ⬇️
....Testing.Platform/Hosts/TestHostOchestratorHost.cs 55.17% <22.22%> (-14.83%) ⬇️
...stHostOrcherstrator/TestHostOrchestratorManager.cs 78.72% <68.18%> (-9.28%) ⬇️

... and 60 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Youssef1313 Youssef1313 force-pushed the dev/ygerges/retry-dotnet-test branch from 9bfcbf7 to 763947c Compare June 10, 2025 11:58
@Youssef1313 Youssef1313 force-pushed the dev/ygerges/retry-dotnet-test branch from 763947c to 59f4c15 Compare June 10, 2025 13:13
@Youssef1313 Youssef1313 marked this pull request as ready for review June 10, 2025 13:18
@Evangelink Evangelink enabled auto-merge (squash) June 11, 2025 19:29
This was referenced Jun 11, 2025
Closed
Closed
@Evangelink Evangelink merged commit 0b16e9e into main Jun 12, 2025
8 checks passed
@Evangelink Evangelink deleted the dev/ygerges/retry-dotnet-test branch June 12, 2025 08:42
@Youssef1313 Youssef1313 mentioned this pull request Jun 18, 2025
Merged
@Copilot Copilot AI mentioned this pull request Jul 16, 2025
Merged
This was referenced Aug 20, 2025
Closed
Open
Open
Open
Closed
Open
Open
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Open
Open
Closed
Closed
Open
Open
Closed
Closed
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Evangelink Evangelink Evangelink approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Microsoft.Testing.Extensions.Retry can't move files from TestResults when running from dotnet test on Windows
3 participants
@Youssef1313 @codecov-commenter @Evangelink