Better handling of MSTest.TestAdapter under .NET Standard #5647
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Evangelink
reviewed
May 27, 2025
src/Adapter/MSTest.TestAdapter/buildTransitive/common/MSTest.TestAdapter.targets
Outdated
Show resolved
Hide resolved
…estAdapter.targets Co-authored-by: Amaury Levé <amauryleve@microsoft.com>
Evangelink
reviewed
May 27, 2025
src/Adapter/MSTest.TestAdapter/buildTransitive/common/MSTest.TestAdapter.targets
Outdated
Show resolved
Hide resolved
…estAdapter.targets
Evangelink
approved these changes
May 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A step towards #5645
Fixes #5579
MSTest.TestAdapter is supposed to be used only by actual test projects, not by helper libraries. So, we shouldn't allow its usage if the project targets .NET Standard. Additionally, MSTest.Sdk shouldn't include MSTest.TestAdapter under .NET Standard. So, we set
IsTestApplicationto false under .NET Standard in MSTest.Sdk.