Write warnings outside of appdomain #5371
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Youssef1313
reviewed
Apr 4, 2025
src/Adapter/MSTest.TestAdapter/Discovery/AssemblyEnumeratorWrapper.cs
Outdated
Show resolved
Hide resolved
Youssef1313
previously approved these changes
Apr 4, 2025
|
I am finally happy with the test, I had to change how project assets are emitted, to put them to the same folder (but different subfolders, like if we had a solution). I don't expect anything to break because 90% of the fixture usages are for 1 project only, and where 2 projects are used, they don't reference each other, because it was not possible till now (they emit to different temp directories). But let's see what breaks. Maybe I will need to go back to writing the code files to disk first, and then building, instead of doing all that in parallel right now. |
Youssef1313
previously approved these changes
Apr 16, 2025
nohwnd
commented
Apr 16, 2025
test/IntegrationTests/MSTest.Acceptance.IntegrationTests/ThreadingTests.cs
Show resolved
Hide resolved
|
I've re-run it on the merge, and not here. AAARGh! |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
fhnaseer
approved these changes
Apr 17, 2025
This was referenced Jul 22, 2025
This was referenced Aug 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #5176
Figuring out a reliable way to test this, will follow up with other PR. Ensured manually that it works.