Skip to content

[MTP v2][Breaking] Revise MTP properties and where they do belong (test node vs update message) #5524

@Youssef1313

Description

@Youssef1313

Many (almost all?) properties are expected to be added today to TestNode, while some of them feel to me they should belong to TestNodeUpdateMessage instead. Examples:

On the other hand, the following properties are present on TestNode today and are correct:

  • TestFileLocationProperty
  • TestMethodIdentifierProperty
  • TestMetadataProperty

In addition, we should also revise Trx-specific properties:

https://github.com/microsoft/testfx/blob/0e87d5aafb41692309b310704c6fa858b146919c/src/Platform/Microsoft.Testing.Extensions.TrxReport.Abstractions/TrxReportProperties.cs

  • TrxExceptionProperty, likely needs to be moved to TestNodeUpdateMessage
  • TrxFullyQualifiedTypeNameProperty good on TestNode.
  • TrxMessagesProperty, likely needs to be moved to TestNodeUpdateMessage
  • TrxCategoriesProperty good on TestNode

Metadata

Metadata

Assignees

No one assigned

    Labels

    Area: MTPBelongs to the Microsoft.Testing.Platform core libraryBreaking ‼️

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions