-
Notifications
You must be signed in to change notification settings - Fork 285
Closed as not planned
Closed as not planned
Copy link
Labels
Area: MTPBelongs to the Microsoft.Testing.Platform core libraryBelongs to the Microsoft.Testing.Platform core libraryBreaking ‼️
Milestone
Description
Many (almost all?) properties are expected to be added today to TestNode, while some of them feel to me they should belong to TestNodeUpdateMessage instead. Examples:
- TimingProperty
- This doesn't feel like a property of TestNode itself, but rather a success/fail/error/timeout/cancel update message.
- Fixed in Move some MTP properties from TestNode to TestNodeUpdateMessage #6124
- TestNodeStateProperty (and derived)
- The name gives impression that it's property of the test node, but I also tend to think it belongs to TestNodeUpdateMessage. Take the case of folded tests in MSTest where we will report multiple results for the same TestNode. To me that's an indicator that the property belongs to the update message not the node itself.
- StandardOutputProperty/StandardErrorProperty
- FileArtifactProperty
On the other hand, the following properties are present on TestNode today and are correct:
- TestFileLocationProperty
- TestMethodIdentifierProperty
- TestMetadataProperty
In addition, we should also revise Trx-specific properties:
-
TrxExceptionProperty
, likely needs to be moved toTestNodeUpdateMessage
-
TrxFullyQualifiedTypeNameProperty
good onTestNode
. -
TrxMessagesProperty
, likely needs to be moved toTestNodeUpdateMessage
-
TrxCategoriesProperty
good onTestNode
Evangelink
Metadata
Metadata
Assignees
Labels
Area: MTPBelongs to the Microsoft.Testing.Platform core libraryBelongs to the Microsoft.Testing.Platform core libraryBreaking ‼️