Implement jitter in @Retryable to avoid thundering herd #11805
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
injae-kim
reviewed
May 17, 2025
| * @return The jitter factor used to apply random deviation to retry delays | ||
| */ | ||
| @Digits(integer = 1, fraction = 2) | ||
| String jitter() default "0.25"; |
There was a problem hiding this comment.
Suggested change
| String jitter() default "0.25"; | |
| String jitter() default "0.0"; |
should be set default jitter to 0? (jitter 0 means don't apply jitter by default)
There was a problem hiding this comment.
That's a valid point. Thank you for the suggestion!
| @@ -173,6 +187,10 @@ public Class<? extends Throwable> getCapturedException() { | |||
| public long nextDelay() { | |||
| double multiplier = getMultiplier().orElse(1.0); | |||
| long delay = (long) ((getDelay().toMillis()) * pow(multiplier, attemptNumber.get() - 1)); | |||
| double jitter = getJitter().orElse(0); | |||
| if(jitter > 0) { | |||
There was a problem hiding this comment.
Suggested change
| if(jitter > 0) { | |
| if (jitter > 0) { |
nit. indent
yawkat
requested changes
May 19, 2025
| /** | ||
| * @return The jitter factor used to apply random deviation to retry delays | ||
| */ | ||
| OptionalDouble getJitter(); |
There was a problem hiding this comment.
Thanks for the feedback! I've updated the PR to include the default implementation.
I'd appreciate any further comments you might have.
yawkat
approved these changes
May 19, 2025
|
Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a jitter parameter to the
@Retryableannotation, as requested in issue #11631.Closes #11631