Catch IllegalArgumentException in VirtualThreadMetrics #6584
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IllegalArgumentException may be thrown by ManagementFactory#getPlatformMXBean() in case if is not a platform management interface or not a singleton platform MXBean. Signed-off-by: Alexey Genus <genus.alexey@gmail.com>
c177071 to
bbc25dd
Compare
jonatan-ivanov
approved these changes
Aug 1, 2025
|
Thanks for the PR!
Since the exception is swallowed I think it's fine to keep them narrower. (Catching Exception and log it out might make sense though, but I think that could be in another PR on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to javadoc
getPlatformMXBeanmay throwIllegalArgumentExceptionin case ifmxbeanInterfaceis not a platform management interface or not a singleton platform MXBean. This is currently the case for graalvm native image (at least for 24.0.2).I hesitated to add a test, but it looks a bit excessive. I also thought, maybe it's better to catch all
j.l.Exceptions for simplicity?