Add StackdriverConfig autoCreateMetricDescriptors option #6403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shakuzen
requested changes
Jun 16, 2025
...registry-stackdriver/src/main/java/io/micrometer/stackdriver/MetricServiceClientFactory.java
Outdated
Show resolved
Hide resolved
...r-registry-stackdriver/src/main/java/io/micrometer/stackdriver/StackdriverMeterRegistry.java
Show resolved
Hide resolved
...ackdriver/src/main/java/io/micrometer/stackdriver/StackdriverMetricServiceClientFactory.java
Outdated
Show resolved
Hide resolved
.../test/java/io/micrometer/stackdriver/StackdriverMeterRegistryDescriptorAutoCreationTest.java
Outdated
Show resolved
Hide resolved
939686c to
afdc950
Compare
|
Thank you very much for the quick review, I've addressed the comments :) |
This option can be used to disable the automatic metric descriptor creation behaviour when descriptors are instead managed using IaC. Signed-off-by: Shaderbug <119610832+shaderbug@users.noreply.github.com>
afdc950 to
555dbc3
Compare
izeye
added a commit
to izeye/micrometer
that referenced
this pull request
Jun 28, 2025
Signed-off-by: Johnny Lim <izeye@naver.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #6281 by making the automatic creation of Stackdriver metric descriptors configurable via a configuration property.
To be able to unit-test the behaviour, I have introduced a new
MetricServiceClientFactoryclass, that can be replaced in tests.Looking forward to your feedback :)