Bump io.dropwizard.metrics5:metrics-core from 5.0.0 to 5.0.1 #6447
Conversation
Bumps [io.dropwizard.metrics5:metrics-core](https://github.com/dropwizard/metrics) from 5.0.0 to 5.0.1. - [Release notes](https://github.com/dropwizard/metrics/releases) - [Commits](dropwizard/metrics@v5.0.0...v5.0.1) --- updated-dependencies: - dependency-name: io.dropwizard.metrics5:metrics-core dependency-version: 5.0.1 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
1364143 to
348f109
Compare
|
Dropwizard increased the Java baseline from Java 8 to 17 in a patch release, see: dropwizard/metrics#4839 |
|
Reading the discussion at that issue, I guess we shouldn't have been using 5.0.0 all this time. If its usage is limited to our benchmarks, maybe it's easiest to make the benchmark module minimum Java 17? That might be annoying if we ever want to investigate a performance issue specific to Java 8/11, but practically speaking, I don't think we've had that so far. |
|
Alternatively, at least for maintenance branches, maybe it makes sense to remove the benchmarks depending on dropwizard 5? We can figure out what to do on main separately. |
|
Looks like io.dropwizard.metrics5:metrics-core is no longer a dependency, so this is no longer needed. |
Pull request was closed
Bumps io.dropwizard.metrics5:metrics-core from 5.0.0 to 5.0.1.
Release notes
Sourced from io.dropwizard.metrics5:metrics-core's releases.
Commits
288b22a[maven-release-plugin] prepare release v5.0.17df220e[maven-release-plugin] prepare for next development iterationDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)