Skip to content

Replace TimeUtils usage to TimeUnit where applicable #6224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 21, 2025
Merged

Replace TimeUtils usage to TimeUnit where applicable #6224

merged 3 commits into from
May 21, 2025

Conversation

ngocnhan-tran1996
Copy link
Contributor

Closes gh-6215

@ngocnhan-tran1996 ngocnhan-tran1996 deleted the gh-6215 branch May 11, 2025 22:05
@ngocnhan-tran1996 ngocnhan-tran1996 restored the gh-6215 branch May 11, 2025 22:23
@ngocnhan-tran1996 ngocnhan-tran1996 force-pushed the gh-6215 branch 2 times, most recently from 55e8f6a to 14415ac Compare May 11, 2025 23:07
@shakuzen shakuzen requested a review from jonatan-ivanov May 14, 2025 05:11
@ngocnhan-tran1996 ngocnhan-tran1996 force-pushed the gh-6215 branch 2 times, most recently from f361df8 to 8df8750 Compare May 15, 2025 11:30
@jonatan-ivanov jonatan-ivanov changed the title Add long overloads for methods of TimeUtils Replace TimeUtils usage to TimeUnit where applicable May 19, 2025
@jonatan-ivanov jonatan-ivanov mentioned this pull request May 19, 2025
Closed
@jonatan-ivanov jonatan-ivanov added this to the 1.13.15 milestone May 19, 2025
@jonatan-ivanov jonatan-ivanov added type: task A general task polish A general improvement (naming things, fixing minor issues, etc.) labels May 19, 2025
@ngocnhan-tran1996 @jonatan-ivanov
Add long overloads for methods
fcb4e33 
Signed-off-by: Tran Ngoc Nhan <ngocnhan.tran1996@gmail.com>
@ngocnhan-tran1996 @jonatan-ivanov
Use TimeUnit
c9fea0c 
Signed-off-by: Tran Ngoc Nhan <ngocnhan.tran1996@gmail.com>
@ngocnhan-tran1996 @jonatan-ivanov
Fix checkstyle
622f399 
Signed-off-by: Tran Ngoc Nhan <ngocnhan.tran1996@gmail.com>
@jonatan-ivanov jonatan-ivanov changed the base branch from main to 1.13.x May 21, 2025 21:35
@jonatan-ivanov jonatan-ivanov merged commit 556d5b6 into micrometer-metrics:1.13.x May 21, 2025
6 checks passed
@jonatan-ivanov
Copy link
Member

Thank you!

@ngocnhan-tran1996 ngocnhan-tran1996 deleted the gh-6215 branch May 22, 2025 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonatan-ivanov jonatan-ivanov jonatan-ivanov approved these changes

@shakuzen shakuzen shakuzen approved these changes

Assignees
No one assigned
Labels
polish A general improvement (naming things, fixing minor issues, etc.) type: task A general task
Projects
None yet
Milestone
1.13.15
Development

Successfully merging this pull request may close these issues.

Add long overloads for methods of TimeUtils
3 participants
@ngocnhan-tran1996 @jonatan-ivanov @shakuzen