Use String.toLowerCase()/toUpperCase() with Locale.ROOT consistently #5711
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit also adds Checkstyle rules for it.
shakuzen
approved these changes
Nov 28, 2024
izeye
added a commit
to izeye/micrometer
that referenced
this pull request
Apr 24, 2025
See micrometer-metricsgh-5711 Signed-off-by: Johnny Lim <izeye@naver.com>
izeye
added a commit
to izeye/micrometer
that referenced
this pull request
Apr 24, 2025
…check from Error Prone See micrometer-metricsgh-5711 Signed-off-by: Johnny Lim <izeye@naver.com>
jonatan-ivanov
pushed a commit
that referenced
this pull request
Apr 24, 2025
See gh-5711 Signed-off-by: Johnny Lim <izeye@naver.com>
jonatan-ivanov
added a commit
that referenced
this pull request
Apr 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes to use
String.toLowerCase()andString.toUpperCase()with theLocale.ROOTconsistently as it seems to be a good practice aside from security.This PR also adds Checkstyle rules for it.
See spring-projects/spring-framework#33708 and https://errorprone.info/bugpattern/StringCaseLocaleUsage