Skip to content

WavefrontConfig should not be a PushRegistryConfig anymore #1967

@snicoll

Description

@snicoll

In PushRegistryConfig we have two deprecated properties to configure the connection and read timeouts. With the move to WavefrontSender, Micrometer does not use an http client at all and therefore those attributes aren't used.

On the Spring Boot side of things, we still expose those two attributes as we auto-configure the HTTP client for the user and we use those settings to tune it. However, in the case of Wavefront, we have no other choice than removing those two properties.

This makes it a bit awkward given the contract provided by Micrometer. I understand this isn't possible for backward compatible reasons, but it would be nice to have a plan to reflect the fact those two attributes aren't used at all with Wavefront.

Metadata

Metadata

Assignees

No one assigned

    Labels

    wontfixA suggestion or change that we don't feel we should currently apply

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions