-
Notifications
You must be signed in to change notification settings - Fork 1k
Closed
Labels
bugA general bugA general buginstrumentationAn issue that is related to instrumenting a componentAn issue that is related to instrumenting a componentmodule: micrometer-coreAn issue that is related to our core moduleAn issue that is related to our core module
Milestone
Description
Describe the bug
This warning
in Caffeine cache metrics is misleading as "except 'cache.size'" phrase is simply not true (i mean that cache.size
also isn't registered). Resolving size uses the same getOrDefault method as the rest of the metrics. This method resolves to null when recording is disabled.
Environment
I see that bug in the newest source code.
To Reproduce
- Create cache with unique name without enabling stats recording.
- Bind cache to MeterRegistry
- Observe that no cache.size metric is sent for typed cache name.
Expected behavior
Warn log shouldn't be misleading or if possible caffeine cache implementation should register cache.size
metric even without stats recording being enabled.
Metadata
Metadata
Assignees
Labels
bugA general bugA general buginstrumentationAn issue that is related to instrumenting a componentAn issue that is related to instrumenting a componentmodule: micrometer-coreAn issue that is related to our core moduleAn issue that is related to our core module