You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a command line option/environment variable to control the bind address. Previously it was always left blank, causing the server to listen on all addresses. This is still the default behavior. The primary use-case I see for this is for when a user wants the server to only be accessible from localhost (so bind to 127.0.0.1). Another possible use-case would be when a server has both publicly accessible interfaces and internal interfaces, though I expect this configuration is uncommon.
I would prefer a flag like -http-addr which defaults to :port, meaning 0.0.0.0:8080, but can be 127.0.0.1:port if needed. The new -http-addr flag would be used over the -port flag if specified, so that things remain backwards compatible.
How's this? There is now a -http-addr flag in the format 127.0.0.1:1234 in addition to the old -port. If both are set, either via flags or environment variables, the program will refuse to start.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a command line option/environment variable to control the bind address. Previously it was always left blank, causing the server to listen on all addresses. This is still the default behavior. The primary use-case I see for this is for when a user wants the server to only be accessible from localhost (so bind to 127.0.0.1). Another possible use-case would be when a server has both publicly accessible interfaces and internal interfaces, though I expect this configuration is uncommon.