Expect SHA-256 instead of MD5 fingerprint flag value #160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessepeterson
approved these changes
Mar 22, 2021
README.md
Outdated
| @@ -119,7 +119,7 @@ cat - > /tmp/scep.csr | |||
| $ ./scepclient-linux-amd64 -help | |||
| Usage of ./scepclient-linux-amd64: | |||
| -ca-fingerprint string | |||
| md5 fingerprint of CA certificate for NDES server. | |||
| (Note: Changed from MD5) SHA-256 digest of CA certificate for NDES server. | |||
There was a problem hiding this comment.
Also, thanks for remember to update the docs! :)
cmd/scepclient/scepclient.go
Outdated
| @@ -268,7 +269,7 @@ func main() { | |||
|
|
|||
| // in case of multiple certificate authorities, we need to figure out who the recipient of the encrypted | |||
| // data is. | |||
| flCAFingerprint = flag.String("ca-fingerprint", "", "md5 fingerprint of CA certificate for NDES server.") | |||
| flCAFingerprint = flag.String("ca-fingerprint", "", "(Note: Changed from MD5) SHA-256 digest of CA certificate for NDES server.") | |||
There was a problem hiding this comment.
nit: place note behind new description
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves issue #156.
Copying the issue description here to save readers' time.
This is to complete pull request #144 which should have removed all weak hash functions usages.
scep/cmd/scepclient/scepclient.go
Line 271 in c892534