Add CertsSelector option #147
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jessepeterson WDYT? |
|
@pavolmarko FYI! |
scep/certs_selector.go
Outdated
| } | ||
|
|
||
| // NopCertsSelector is a CertsSelector that does not do anything. | ||
| type NopCertsSelector struct{} |
There was a problem hiding this comment.
Just a nit, but I kinda like the HandlerFunc pattern over the empty structs. I.e.:
type CertsSelectorFunc func([]*x509.Certificate) []*x509.Certificate
func (f *CertsSelectorFunc) SelectCerts(certs []*x509.Certificate) []*x509.Certificate {
return f(certs)
}And then NopSelector becomes:
func NopCertsSelector() CertsSelectorFunc {
return func(certs []*x509.Certificate) []*x509.Certificate {
return certs
}
}Thoughts?
There was a problem hiding this comment.
Done
I am still super new to Go, so you may find me adapting best practices of other languages. Thanks for teaching me the Go way of doing things :-)
| import "crypto/x509" | ||
|
|
||
| // CertsSelectorFunc is a type of function that filters certificates. | ||
| type CertsSelectorFunc func([]*x509.Certificate) []*x509.Certificate |
There was a problem hiding this comment.
Oh, sorry! Didn't mean to get rid of the CertsSelector interface. Just that CertsSelectorFunc satisfies the CertsSelector interface. So folks can provide the implementation that they want.
This was referenced Mar 19, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #145, some CAs don't have
KeyUsageKeyEnciphermentkey usage set in their certificates. This PR introducesCertsSelectorwhich should make it easier for clients that want to enforce a custom criteria on how to filter certificates.