Encode CSRs only with certificates with KeyEncipherment KeyUsage #136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omorsi
commented
Feb 24, 2021
|
@pavolmarko FYI! |
groob
requested changes
Feb 25, 2021
scep/scep_test.go
Outdated
| shouldCreateCSR bool | ||
| } | ||
|
|
||
| var testNewCSRRequestData = []testNewCSRRequestStruct{ |
There was a problem hiding this comment.
I'd move both the struct and variable inside the function and refactor the for loop to use t.Run.
Example here (t.Parallel optional): https://github.com/golang/go/wiki/TableDrivenTests#parallel-testing
There was a problem hiding this comment.
Thanks for letting me know about that. That's way cleaner :-)
scep/scep_test.go
Outdated
|
|
||
| // GenerateSubjectKeyID generates SubjectKeyId used in Certificate | ||
| // ID is 160-bit SHA-1 hash of the value of the BIT STRING subjectPublicKey | ||
| func generateSubjectKeyID(pub crypto.PublicKey) ([]byte, error) { |
groob
approved these changes
Feb 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to solve issue #123.
Copying the issue description here to save readers' time.
Currently, the CSR sent in a PKCSReq message is encrypted with all the certificates returned from GetCaCert operation.
scep/scep/scep.go
Line 448 in f3adbb7
A windows SCEP server may not just return the CA certificate, but also NDES certificates. Some of these certificates are not created with KeyEncipherment KeyUsage. Some of them are only for Digital Signature purposes. Adding these certificates as recipients for the encrypted messages introduces decryption errors from the server's side.
The proposal here is to filter the certificates received from GetCaCert by KeyUsage, particularly KeyEncipherment, and use only those as the encrypted content recipients.