Skip to content

Copy email addresses from CSR SANs to the X509 template #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 6, 2020

Conversation

m-barthelemy
Copy link
Contributor

This allows generating certificates that can be used for purposes such as VPN authentication, where it might be desirable to identify the user by their email address.

@groob
Copy link
Member

groob commented May 29, 2020

Will try to test it before merging, but I'm not opposed!

@m-barthelemy
Copy link
Contributor Author

m-barthelemy commented May 30, 2020

Thanks, that'd be great!
We've tested it internally by deploying a test SCEP profile to a few laptops, with the following key:

            <key>SubjectAltName</key>
            <dict>
                <key>rfc822Name</key>
                <string>user.email@domain.tld</string>
            </dict>

And we successfully got certificates containing the email of the user on these devices.

@m-barthelemy
Copy link
Contributor Author

Hi @groob ,
Do you have any concern regarding this PR?
Or do you need any help to test it?

@groob
Copy link
Member

groob commented Jun 6, 2020

Just short on time. Your contribution looks good. Thank you for taking the effort/following up!

@groob groob merged commit e9687ba into micromdm:master Jun 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants