Build docker image from current build, not static version #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please take a look at this, @groob. I forgot to add description when creating the pull request yesterday, but I have updated it now. I suggest we improve the Makefile to include a target for docker build as well, but I thought I'd start with just the Dockerfile. I like the way MicroMDM's Makefile creates versions, and suggest we use the same logic for SCEP. If you agree, I can do some Makefile improvements as well. |
groob
approved these changes
May 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that the existing Dockerfile downloaded a release version and installed it in the image. I don't really see how that approach is usable other than for generating an image based on a specific release version of the SCEP server. In any case, the user should be able to download a specific version directly from Docker hub instead.
With the Dockerfile in this pull request, the image is built using the compiled version of SCEP server/client.
The entrypoint is set to start the server, but the user can just override it on container start to start the scep client instead.