Dockerfile improvements #74
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Validate the downloaded artifact's checksum - Expose default port - Use a volume for the default depot - Use the healtcheck feature
groob
reviewed
Nov 6, 2017
Dockerfile
Outdated
|
|
||
| EXPOSE 8080 | ||
| VOLUME ["/depot"] | ||
| HEALTHCHECK --interval=30s --timeout=5s --retries=3 \ |
There was a problem hiding this comment.
This is too opinionated. Please remove the healthcheck line from the dockerfile.
There was a problem hiding this comment.
I can agree, though the idea was to override it for different needs doing the right thing by default. Removed in following commit.
Based on micromdm#74 feedback
groob
approved these changes
Nov 11, 2017
|
Thanks for checking in. I agree that we need a healthcheck, and will add a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The operation GetCACaps for the health check is perhaps not ideal.