-
Notifications
You must be signed in to change notification settings - Fork 136
Closed
Description
Since SHA-1 is insecure (attacks), this issue is to propose to stop supporting clients using it to sign CSRs.
SHA-1 can be used to sign CSRs using micromdm/scep in the following cases:
- The scepclient default behavior is to sign CSRs using SHA1WithRSA. (This can be changed to SHA256WithRSA)
Line 46 in 1078401
SignatureAlgorithm: x509.SHA1WithRSA, - Also signers can use SHA-1 if a challenge need to be added (This can be changed by removing SHA-1 support from x509util)
scep/cryptoutil/x509util/x509util.go
Line 308 in 1078401
{x509.SHA1WithRSA, oidSignatureSHA1WithRSA, x509.RSA, crypto.SHA1}, - Also if the underlying crypto/x509 library supports SHA-1, CSRs with no challenge added can be created using signatures with SHA-1 (this case can't be controlled from micromdm/scep, maybe stopping the process and showing a warning)
Metadata
Metadata
Assignees
Labels
No labels