Skip to content

Conversation

mrmlnc
Copy link
Contributor

@mrmlnc mrmlnc commented Feb 16, 2020

Description

This is a fix for #196.

Looks like yarn does not update transitive dependencies (1, 2). Context.

I understand it looks like a crutch/kludgy, but… this looks correct, because in fact, this package should guarantee to work with all versions of picomatch starting from the specified one.

@mrmlnc
Copy link
Contributor Author

mrmlnc commented Feb 16, 2020

@jonschlinkert, I think we can merge this PR and release a patch version.

@mrmlnc
Copy link
Contributor Author

mrmlnc commented Feb 17, 2020

@doowb, Any chance you release the new version?

@mrmlnc
Copy link
Contributor Author

mrmlnc commented Feb 18, 2020

@jonschlinkert, @doowb, friendly ping :)

@jonschlinkert
Copy link
Member

@mrmlnc really sorry for the delay. I wasn't feeling well for a few days this past week, just getting caught up. I'll review ASAP.

@jonschlinkert jonschlinkert merged commit 250c724 into micromatch:master Feb 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants