Partial Ollama support #49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
There was a problem hiding this comment.
Pull Request Overview
This PR adds partial support for Ollama and improves tool argument parsing to better handle invalid inputs for tool calls.
- Updated tests and configuration to include CONFIG_VERSION and new provider details.
- Added new LLMProviderConfig entries for Ollama support (currently disabled) and updated provider lookup.
- Enhanced tool argument parsing logic in conversation handling to repair minor JSON formatting issues.
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| e2e_tests/test_basic_conversation.py | Updated test configuration to include CONFIG_VERSION. |
| e2e_tests/conftest.py | Modified allowed hosts and updated default model strings, added CONFIG_VERSION. |
| docs/supported-providers.md | Revised documentation to list supported providers including Ollama. |
| custom_components/custom_conversation/providers.py | Introduced new provider configurations for Ollama; commented out enabled entries. |
| custom_components/custom_conversation/conversation.py | Added argument parsing utility functions and updated model formatting for LLM completion. |
Files not reviewed (1)
- .vscode/settings.json: Language not supported
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #49 +/- ##
==========================================
- Coverage 47.90% 47.44% -0.47%
==========================================
Files 10 10
Lines 1075 1096 +21
Branches 163 166 +3
==========================================
+ Hits 515 520 +5
- Misses 530 546 +16
Partials 30 30 ☔ View full report in Codecov by Sentry. |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add some support for Ollama. Native support is currently disabled until these two issues have been resolved:
BerriAI/litellm#6135
BerriAI/litellm#9602
This does, however, add some tool argument parsing fixes that improve tool calling ability through Ollama's OpenAI API.